Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Bpm from EngineBuffer and BpmControl #4064

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Return Bpm from EngineBuffer and BpmControl #4064

merged 2 commits into from
Jul 7, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Jul 6, 2021

This also fixes a potential division by zero in EngineBuffer, in case thisLocalBpm is invalid.

Holzhaus added 2 commits July 6, 2021 23:09
@Holzhaus
Bpm: Add method to to divide by another Bpm
93ef4ff
@Holzhaus
EngineBuffer: Return Bpm type from getBpm/getLocalBpm methods
9dc9d26 
This also fixes a potential division by zero, in case `thisLocalBpm` is
invalid.
@Holzhaus Holzhaus requested a review from ywwg July 6, 2021 21:14
uklotzde
uklotzde approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to merge this PR.

daschuer
daschuer approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM

@daschuer daschuer merged commit f3d9ad1 into mixxxdj:main Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

@uklotzde uklotzde uklotzde approved these changes

@ywwg ywwg Awaiting requested review from ywwg

Assignees
No one assigned
Labels
code quality
Projects
Semanting Type Refactoring
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Holzhaus @uklotzde @daschuer