Library: resize the Played checkbox and BPM lock with the library font

[ronso0]

This should resize the 'Played' checkbox and the BPM lock icon to match the library font.
(another snippet to fix https://bugs.launchpad.net/mixxx/+bug/1736001)
This works well for library font sizes up to 200% of the original system font's size. Above that, the indicators start to overlap the item text because the painter rectangle is not resized (also depending on the system font size).

Admittedly this can be considered a stupid hack, but I have not found a more efficient way, and the solution should be fine for now.
For the BPM delegate this could be done in paintItem() by resizing the painter rectangle, but I didn't find a way to access the Played indicator like that.

System 11pt (Qt5 Settings 11pt), library 22pt
This PR

2.3

[ronso0]

Please test this on Linux, Windows (@JoergAtGithub ?) and macOS (@foss- ?) if this works in general.

Meanwhile I'll test if the Played checkbox needs some adjustment.

[foss-]

Build artifact 2.3.0-14-g89fd8ec131 (HEAD)
Size of lock and played check mark unchanged:
2.3

This PR

[ronso0]

@foss- Do you have any screens showing the previous state?
Indeed the BPM icon appears to be a tiny bit smaller than in my screens. I could just make it a bit bigger than the checkbox.

[foss-]

I do not want to go back to pre 2.3 versions to avoid problems. But I am certain that lock icon previously had the size from your screenshot for this PR.

[ronso0]

I do not want to go back to pre 2.3 versions to avoid problems

Of course, I thought maybe you have still some screenshots somewere.

Can you please reset the mac app scaling to 100% and share a screenshot with that?
Also I'd like to see a screenshot with your usual app scaling, just to see how certain widgets are displayed (for example, I see that gap in between the BPM lock / Played checkmark and the respective items labels only if I use a scale factor >100% but don't scale up the library font so it matches the size all other text labels)

Then, if you don't mind, please try the current build artifact and share a screenshot: I made the BPM and Played icons as big as those in the main menus on other OS, and the Played checkbox is now also a SVG instead of a css border.
For me this works really well for all (reasonable) combinations of system font size and library font size.

[ronso0]

I'll test this on Windows myself soonish.

[foss-]

back to expected size on macOS 11.4, mixxx 2.3.0-21-g26af2937c5 (HEAD)

Played column however has changed and is now showing a play counter. I am not sure if that is expected. that seems to be the total plays while in earlier versions I thought it was an indicator of whether a track has been playing during current set or not (see previous screenshots).

[JoergAtGithub]

On Windows7 it looks the same:

[ronso0]

Played column however has changed and is now showing a play counter. .... it was an indicator of whether a track has been playing during current set or not

It's both, like ever since : ) you're column was to narrow to show the counter.

Played checkbox is now restored, I did too much cleanup ;)

If you can confirm it looks fine on macOS and Windows (also try changing the library font size as this is the actual purpose of this PR) I'll change the other skins, too.

[foss-]

getting closer: check mark still missing:

Deere is fine though:

[JoergAtGithub]

Now it looks on Win7 like this:
20px (Default):

24px:

16px:

[ronso0]

check mark still missing

uff, embarassing, that was caused by a left-over comma in the wrong place...
sorry for not getting this tiny PR done in one go (tried to fix during my son's siesta, but didn't test properly : )
it's fine now. the other skins are tweaked, too.

@JoergAtGithub Looks like you adjusted the lib row height, not the font size ; )

[foss-]

...and we have a winner. Looking good. Thanks for tackling this.

[ronso0]

okay, thanks for testing!
If someone has a few minutes to test the other skins/color schemes we can merge.

[foss-]

Deere

Shade

Tango

All good on macOS.

[ywwg]

@ronso0

This broke the checkboxes in the right-click menu of track header view:

Narrowed down with git bisect:

ea37e7df74216378741c427c80c04ebbd34e5188 is the first bad commit
commit ea37e7df74216378741c427c80c04ebbd34e5188
Author: ronso0 <ronso0@mixxx.org>
Date:   Wed Jul 7 03:17:24 2021 +0200

    Skins / library: resize the Played checkbox and BPM lock with the library font

[ronso0]

whoopsy..
fixed with 49b08aa