Basic QML Sidebar placeholder #4037
Conversation
|
Qt does have a TreeView for QQC2 now, but obnoxiously it is in the "Qt marketplace" instead of packaged with Qt. It is licensed GPL to pressure companies using Qt as LGPL to pay for proprietary licenses. |
|
There is some discussion about packaging difficulties with the Qt Marketplace thing on this bug report. Looking at the Git repository, it seems they recently added or are currently working on Qt6 support with CMake. |
|
Kirigami Addons also has a TreeView. |
|
Hah, I linked the marketplace tree view above, but I didn't notice the "Also available:GPLv3" and thought it was premium only. |
I'd like to avoid pulling in all kinds of KDE dependencies. I'll check the marketplace tree view first. |
|
Kirigami does not depend on other KDE Frameworks libraries. |
|
An MVP with limited functionality is fine. Let's first explore how far we can get with the available components before we pull in new libraries. Maybe we discover a more appropriate solution for the side bar functionality along the way. I like the lightweight approach of first mimicking the status quo by reusing as much of the existing functionality as possible and to determine any functional or conceptual gaps. |
I agree. The issue here is that Qt Quick Controls 1 is deprecated and removed in Qt6. So if we want to get it working with Qt6, we need to get rid of the Qt Quick Controls 1 TreeView first. I already tried to get the Qt Quick 2 tree view working, but there is no cmakelists for Qt5, just Qt 6. I'm looking into it. |
src/skin/qml/qmllibraryproxy.h
Outdated
| Q_INVOKABLE QAbstractItemModel* getSidebarModel(); | ||
|
|
||
| private: | ||
| Library* m_pLibrary; |
There was a problem hiding this comment.
How about using QPointer or mixxx::SafeQPointer to prevent dangling pointers?
This reverts commit fce26e2, reversing changes made to 787b8aa. Superseedes mixxxdj#4410.
Revert "Merge pull request #4037 from Holzhaus/qml-sidebar"
This reverts commit fce26e2, reversing changes made to 787b8aa. Superseedes mixxxdj#4410.
Follow-up to #4034.
This now exposes the SidebarModel to QML and adds an actual treeview to the QML skin.
Top level items are displayed, including icons.
For now, those items are not clickable (nothing happens) and the lazy loading mechanic (e.g. browse feature) is not working. For stuff like that to work, some more serious refactoring is needed. The same goes for child item icons.
Unfortunately, Qt Quick Control 2 does not provide a TreeView (they made that a premium feature), so this still uses the old Qt Quick Controls 1 TreeView component. We may evaluate existing solutions or roll our own in the future.