-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QML: Add support for deck cloning #4004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea: set Drag.imageSource to the coverart
@@ -13,6 +13,20 @@ Item { | |||
property bool minimized: false | |||
property var deckPlayer: Mixxx.PlayerManager.getPlayer(group) | |||
|
|||
Drag.active: dragArea.drag.active |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is causing problems:
warning [Main] file:///home/swiftb0y/Sourcerepositories/mixxx/res/skins/QMLDemo/DeckRow.qml:71:5: QML Deck (parent or ancestor of QQuickDragAttached): Binding loop detected for property "active"
You can reproduce it by dragging the deck to any Item that has no PlayerDropArea, and then clicking anywhere else in the skin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot reproduce this. It's not even possible to drag stuff anywhere else, the mouse pointer becomes a "no waiting" road sign.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, that line is taken from the QML Drag & Drop example: https://doc.qt.io/qt-5/qtquick-draganddrop-example.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot reproduce this. It's not even possible to drag stuff anywhere else, the mouse pointer becomes a "no waiting" road sign.
Mhmm. I don't even have a change in mouse pointer. I guess its an underlying bug with Qt and the window manager or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can worry about this some other time.
8ad4dbe
to
297cfee
Compare
297cfee
to
dba59c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merge?
Yup :D |
This makes it possible to clone decks via drag and drop.