Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QML: Add support for deck cloning #4004

Merged
merged 4 commits into from
Jun 20, 2021
Merged

Conversation

Holzhaus
Copy link
Member

This makes it possible to clone decks via drag and drop.

@github-actions github-actions bot added the skins label Jun 15, 2021
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea: set Drag.imageSource to the coverart

@@ -13,6 +13,20 @@ Item {
property bool minimized: false
property var deckPlayer: Mixxx.PlayerManager.getPlayer(group)

Drag.active: dragArea.drag.active
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing problems:

warning [Main] file:///home/swiftb0y/Sourcerepositories/mixxx/res/skins/QMLDemo/DeckRow.qml:71:5: QML Deck (parent or ancestor of QQuickDragAttached): Binding loop detected for property "active"

You can reproduce it by dragging the deck to any Item that has no PlayerDropArea, and then clicking anywhere else in the skin.

Copy link
Member Author

@Holzhaus Holzhaus Jun 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot reproduce this. It's not even possible to drag stuff anywhere else, the mouse pointer becomes a "no waiting" road sign.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, that line is taken from the QML Drag & Drop example: https://doc.qt.io/qt-5/qtquick-draganddrop-example.html

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot reproduce this. It's not even possible to drag stuff anywhere else, the mouse pointer becomes a "no waiting" road sign.

Mhmm. I don't even have a change in mouse pointer. I guess its an underlying bug with Qt and the window manager or something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can worry about this some other time.

src/skin/qml/qmlplayermanagerproxy.cpp Outdated Show resolved Hide resolved
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge?

@Holzhaus
Copy link
Member Author

Yup :D

@Swiftb0y Swiftb0y merged commit dd6928e into mixxxdj:main Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants