Only show the date in Date Added / Last Played columns #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
reviewed
Jun 4, 2021
uklotzde
suggested changes
Jun 4, 2021
uklotzde
reviewed
Jun 4, 2021
|
good idea! done. |
uklotzde
reviewed
Jun 5, 2021
| @@ -625,7 +625,11 @@ QVariant BaseTrackTableModel::roleValue( | |||
| VERIFY_OR_DEBUG_ASSERT(rawValue.canConvert<QDateTime>()) { | |||
| return QVariant(); | |||
| } | |||
| return mixxx::localDateTimeFromUtc(rawValue.toDateTime()); | |||
| QDateTime dt = mixxx::localDateTimeFromUtc(rawValue.toDateTime()); | |||
There was a problem hiding this comment.
You need to enclose the case block in a scope now, like the next one. C++ weirdness.
uklotzde
approved these changes
Jun 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has annoyed me for a while -- I've never wanted to know what time of day I added a track, and the column itself says "date", not "datetime". This makes the columns much more manageable.