SetLogFeature: Reset pointer when WLibrary is destroyed #3940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a crash when loading a legacy skin first, then switching to a QML skin and playing a deck.
daschuer
requested changes
Jun 4, 2021
uklotzde
reviewed
Jun 4, 2021
|
Yes of cause :-) |
|
Btw, we could backport this to 2.3 in case someone creates a legacy skin without WLibrary widget, but I didn't want to touch that so shortly before release. |
|
good point. even though it's rather unlikely someone creates a skin without library, switching to it from a skin that has one would crash Mixxx. though configskin would be saved and loaded on next start, wouldn't it? |
|
No, if Mixxx crashes the config is not saved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash when loading a legacy skin first, then switching to a
QML skin and playing a deck.