Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QML: Enable multisampling #3920

Merged
merged 1 commit into from
May 28, 2021
Merged

Conversation

Holzhaus
Copy link
Member

This makes the spinnies and knob arcs from #3907 look nicer.

@Swiftb0y
Copy link
Member

Swiftb0y commented May 28, 2021

Would it make sense to put this behind a config option so people on weaker systems can benefit from the lower resource consumption with multisampling disabled?

src/skin/qml/qmlskin.cpp Outdated Show resolved Hide resolved
@uklotzde
Copy link
Contributor

Would it make sense to put this behind a config option so people on weaker systems can benefit from the lower resource consumption with multisampling disabled?

Maybe it is sufficient to note this as a TODO together with the constant. Let's implement the default case first and then decide later which degree of customization is actually required.

@Holzhaus Holzhaus force-pushed the qml-multisampling branch from 76d6d5a to 63e56be Compare May 28, 2021 21:21
@Holzhaus
Copy link
Member Author

Done.

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit 63c1855 into mixxxdj:main May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants