Make sure unused places in ChannelHandleMap are initalized #3882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
reviewed
May 20, 2021
uklotzde
reviewed
May 20, 2021
uklotzde
reviewed
May 20, 2021
|
Done |
uklotzde
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The using code assumes that empty places are nullptr, which is not the case:
https://doc.qt.io/qt-5/qvarlengtharray.html
This PR fixes the assumption. And hopefully the rasher in https://bugs.launchpad.net/mixxx/+bug/1775497
Unfortunately the over all design is still broken and instead of crashing it will probably now hit VERIFY_AND_DEBUG_ASSERTs that have been added as safety net.
I think for 2.4 a bigger refactoring is required with a better memory management, fixing these edge cases.
Before building on it in #2618