Track metadata import: Rename enumeration and indicate modifications #3858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
reviewed
May 13, 2021
| @@ -105,7 +105,7 @@ class SoundSourceProxy { | |||
|
|
|||
| /// Controls which (metadata/coverart) and how tags are (re-)imported from | |||
| /// audio files when creating a SoundSourceProxy. | |||
| enum class ImportTrackMetadataMode { | |||
| enum class UpdateTrackFromSourceMode { | |||
There was a problem hiding this comment.
Suggested change
| enum class UpdateTrackFromSourceMode { | |
| enum class UpdateTrackMetadataFromSourceMode { |
?
There was a problem hiding this comment.
We have a class TrackMetadata that doesn't include cover art. Since we update the whole track including the cover info just Track is a better fit and it also closely mirrors the function name.
There was a problem hiding this comment.
The distinction between the different levels of track properties and their naming (TrackMetadata < TrackRecord) could still be improved. But this is not urgent as long as the names are used consistently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small, technical PR: