Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Bump CMAKE_PROJECT_VERSION to 2.4 #3765

Merged
merged 1 commit into from
Apr 16, 2021
Merged

CMake: Bump CMAKE_PROJECT_VERSION to 2.4 #3765

merged 1 commit into from
Apr 16, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Apr 3, 2021

No description provided.

@github-actions github-actions bot added the build label Apr 3, 2021
Be-ing
Be-ing suggested changes Apr 3, 2021
View reviewed changes
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with #3259.

@Holzhaus
Copy link
Member Author

Holzhaus commented Apr 3, 2021

That conflict would be trivial to resolve. The current version is wrong this is is a tiny fix we can easily apply now.

@Be-ing
Copy link
Contributor

Be-ing commented Apr 3, 2021

The point is we should not be using CMAKE_PROJECT_VERSION at all.

@uklotzde
Copy link
Contributor

uklotzde commented Apr 5, 2021

Restoring consistency is a valid reason to merge this PR until the final solution is ready.

@uklotzde
Copy link
Contributor

uklotzde commented Apr 9, 2021

Ping. Agreed?

@Holzhaus Holzhaus force-pushed the cmake-project-version-2.4 branch from 5b18159 to cfce002 Compare April 11, 2021 11:26
@Holzhaus
Copy link
Member Author

Merge?

@uklotzde
Copy link
Contributor

LGTM

@uklotzde uklotzde merged commit ea43752 into mixxxdj:main Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing requested changes

@daschuer daschuer daschuer approved these changes

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Holzhaus @Be-ing @uklotzde @daschuer