PredefinedColorPalettes: Add Rekordbox Hotcue Color Palettes #3746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping / request to merge? |
|
I cannot test this due to https://bugs.launchpad.net/mixxx/+bug/1921549 but the code looks ok and CI passes. LGTM, thank you! |
|
Yikes, I was too quick. This should have went into 2.3, not main. Can you open a new PR? |
|
Oh, yes, sorry, my fault I didn't notice that as well. #3749 |
Holzhaus
added a commit
that referenced
this pull request
Mar 27, 2021
Rekordbox palette (#3746 on 2.3)
daschuer
added a commit
to daschuer/mixxx
that referenced
this pull request
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #3743
Due to the "truncation" of the colors, some position get assigned the same color twice, highlighting the issue I tried to fix in #2902.
I may pick that up again now.