Partly revert 6af7b84e4c49b369838949ccbc1fbe703e13afc7 #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the "pull code from the internet and execute it" part of 6af7b84. CC: Daniel Poelzleithner <git@poelzi.org> Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
|
Don't know what your branching policy and so on is, but maybe this should also be backported? |
Stuff merged into 2.3 will eventually end up in main. |
|
Sorry about that. Since i had problem getting pre-commit to run on 19.09 and 20.03 did not work om my system. I tried to backport first but had problems and thought, its only used in the dev shell, and only as pre commot hook, I accept the hack. |
|
LGTM |
|
Oops, forgot to retarget to 2.3. Will chery-pick into 2.3. |
|
There is no shell.nix in 2.3, nothing to do. |
|
There is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the "pull code from the internet and execute it" part of
6af7b84.
I don't care whether this is necessary for something or what it does. It pulls code from the internet and does not give me the time to check it before running it. This is a no-go.