Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

last_played_at: Fix debug assertion for invalid/missing time stamps #3494

Merged
merged 1 commit into from
Dec 28, 2020
Merged

last_played_at: Fix debug assertion for invalid/missing time stamps #3494

merged 1 commit into from
Dec 28, 2020

Conversation

uklotzde
Copy link
Contributor

A debug assertion is triggered for tracks that have never been played before, i.e. where last_played_at is NULL.

@uklotzde uklotzde added this to the 2.4.0 milestone Dec 28, 2020
@uklotzde uklotzde requested review from ywwg and daschuer December 28, 2020 21:41
daschuer
daschuer approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, that has slipped through. LGTM

@daschuer daschuer merged commit 6d81770 into mixxxdj:main Dec 28, 2020
@uklotzde uklotzde deleted the last_played_at branch January 3, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

@ywwg ywwg Awaiting requested review from ywwg

Assignees
No one assigned
Labels
library major bug
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @daschuer