rename ControllerPreset to LegacyControllerMapping #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd83925 to
32b20d0
Compare
uklotzde
reviewed
Dec 20, 2020
|
Just one minor comment about consistency. I have checked that the group name in the preferences remains unchanged for backwards compatibility. It would be helpful to mention these exceptions in the PR description explicitly. |
|
It might be helpful leave a note about the (now) inconsistent naming in the code where the key "[ControllerPreset]" is defined. |
32b20d0 to
7a8cfcc
Compare
|
Notes addressed, CI passed. |
uklotzde
reviewed
Dec 20, 2020
uklotzde
approved these changes
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last step before decoupling controller hardware I/O from the legacy mapping system.
This is strictly a renaming PR. IF YOU ASK ME TO EXPAND THE SCOPE OF THIS, INCLUDING CODE CLEANUP, I WILL CLOSE THIS PR AND STOP WORKING ON THIS.