-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmakelists and windows_buildenv fixes #3471
Conversation
windows_buildenv.bat : Fixes on the generation of the CMakeSettings.txt
Please fix pre-commit errors. |
Why you changed the type of CMAKE_PREFIX_PATH from path to string? |
Because PATH means that it is a folder, but here it actually is multiple paths, so it is a string. Anyway, there might be something strange going on there, as the CMakeCache that I generated using cmake from commandline has this (UNINITIALIZED) and the one on Visual studio has this (STRING): |
Also used the BUILD_ROOT and INSTALL_ROOT defined in variables, since those can be outside of the project
…xx into windows_cmake_fixes
Did you know that you can download the patch file with the code style fixes as build artifact? https://github.com/mixxxdj/mixxx/suites/1700507024/artifacts/32000776 |
I don't know what's going on with this Windows stuff. @JoergAtGithub do you think this is ready to merge? |
I do not know the purpose of these console settings. Everything else looks reasonful to me. I did not tested it yet. |
Those console settings are in order to create an UTF8 file with a BOM on it. My Visual Studio created file had such a BOM, so I tried to replicate it as much as I could. In most cases, it could work without these changes, but this should ensure that it keeps working on other locales. |
CMakelists.txt: Do not duplicate the runtime binaries on install dir.
windows_buildenv.bat : Fixes on the generation of the CMakeSettings.txt