fix ANGLE OpenGL issues on Windows #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoergAtGithub can you test the artifact from the build on my fork to confirm the issues are fixed? |
|
Waveform preferences in my Windows VM: |
I confirm that the version from this artifact fixes the issues! |
|
Thank you, for fixing this. I have done just a bit single stepping and I am not clear how this ever works without. |
|
Just a side note: |
This was referenced Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #3367 with a fixed CMakeLists.txt that actually installs the ANGLE DLLs. I confirmed it works by testing the artifact in my Windows VM.