-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract HID DeviceInfo from HidController/HidEnumerator #3308
Conversation
uklotzde
commented
Nov 13, 2020
- Split mixxx::hid::DeviceInfo/DeviceCategory from HidController/HidEnumerator
- Move code into reusable functions to reduce code duplication
- Avoid redundant copying and manual memory management
- Use available C/C++ standard functions like strnlen() and wcsnlen()
- Use immutable members where possible
- Detailed logging during device discovery
- Remove unused code/members, e.g. m_sUID
I decided not to target 2.3, because more changes might follow. The HID code of 2.3 will remain as is. |
Clazy failures will be fixed after #3300 has been merged. |
# Conflicts: # src/controllers/hid/hidcontroller.cpp
@Be-ing This is also a small step towards replacing the old controller system. By isolating code that will be needed for both the old and the new controller system we can replace the legacy classes step by step. |
Yes I would like to get confirmation there are no regressions testing with real hardware before merging this. @ywwg @JoergAtGithub @fayaaz could one of you test this? |
The code changes look good to me, just add a little more documentation as noted above. |
I tested this PR on Windows7 and I didn't notice a difference. My device appears with usual name in preferences and my mapping still works. |