Skin updates

[poelzi]

I was putting some love into the deer skin and was able to skin the menubar after some small changes. Since we are skinning, having a default menubar feels like a foreign object, so I consider this 2.3 worthy.

• Deere: option for a larger UV master.
• Indicate green/yellow area in the UV meters
• Allow skinning of menubar Skins: allow menubar to be styled #3372
• Skin Deer Menubar future PR by @ronso0
• Small adjustments of the alpha value for track colors for better visibility (all skins)

[daschuer]

I cannot see a difference in case of Gnome or Unity.
Can you add also a "Before" Screenshot?

[daschuer]

I am in doubt that the large VU Meter should be a preference option. The designer should decide.

[daschuer]

OK there is a difference with Deere:

[poelzi]

I am in doubt that the large VU Meter should be a preference option. The designer should decide.

I differ. Some people might like to have same sized UV meters and this is a simple option that does not much harm.

[poelzi]

I cannot see a difference in case of Gnome or Unity.
Can you add also a "Before" Screenshot?

It depends on your system colors. If you run a dark skin it might look ok, on a light skin, at least on KDE, it looks ugly.

[Holzhaus]

I cannot see a difference in case of Gnome or Unity.
Can you add also a "Before" Screenshot?

It depends on your system colors. If you run a dark skin it might look ok, on a light skin, at least on KDE, it looks ugly.

https://mixxx.org/screenshots/

[ronso0]

OK there is a difference with Deere:

One reason I didn't start working on styles for DlgtrackInfo is that once you start overwriting native styles you need to take care of all other styles, too, and make sure they look good on all platforms. Thus my library menu style PR has grown enormously and has taken ages to finish.

[ronso0]

Please rebase on 2.3 so crash fixes from #3144 are included and this PR is testable.

[ronso0]

I am in doubt that the large VU Meter should be a preference option. The designer should decide.

I differ. Some people might like to have same sized UV meters and this is a simple option that does not much harm.

@Be-ing ??

[poelzi]

@ronso0 I felt your pain yesterday. So, maybe as a quick workaround we could just set the colors of the menus and a border.
With changing check symbols the pain started which might have to do with using SVG as icons, or at least, does not make it easier.

[poelzi]

This is how 2.3 Deer looks with KDE on a light skin.

[ronso0]

@ronso0 I felt your pain yesterday. So, maybe as a quick workaround we could just set the colors of the menus and a border.
With changing check symbols the pain started which might have to do with using SVG as icons, or at least, does not make it easier.

maybe take a look at a system theme and check how menus and checkboxes are styled there.
I doubt it fails because of SVGs, those work in the track menu. You may need to set the indicator size explicitely in css.

[poelzi]

@ronso0 do you have some time helping on this one ? I have so many open points that this styling thing drives me nuts. You wrote that you did some styling of the menus already ?

[ronso0]

I think it'll take an entire evening to look into this and supply comprehensive styles, let alone applying this to all skins.
Unfortunately I don't have time for this until sunday.

[poelzi]

@ronso0 even if it takes you 2 weeks, I would be super happy getting your skilled styling on board here. I tried different things this evening but could not get something look nice everywhere :(

[ronso0]

Are you asking just about the styling or about purging quirks like the one @daschuer experienced?

[ronso0]

@poelzi
I suggest you split this up into smaller chunks to get the finished parts merged

• Deere design
• track color opacity
• menubar styling, c++ requirements (no skin changes): we need to check what happens on macOS, Windows and various linux DEs, and since we're short on active Win/macOS testers it would be better to have style-capable builds available and users can test stylesheets without having to build Mixxx on their own
• WIP menubar stylesheets

[Be-ing]

I agree with @daschuer and @Holzhaus. I am not a fan of the big meter option in Deere. It looks out of place to me and I don't think the option is really helpful. Having more options is not inherently good.

[ronso0]

I agree with @daschuer and @Holzhaus. I am not a fan of the big meter option in Deere. It looks out of place to me and I don't think the option is really helpful.

I think it could be a useful addition and we should make it the default.
But it's to big IMO compared to the channel meters. If we limit it to half the height of the mixer it looks good.
Also let's include the colored meter backpaths.

[ronso0]

• menubar styling, c++ requirements (no skin changes): we need to check what happens on macOS, Windows and various linux DEs, and since we're short on active Win/macOS testers it would be better to have style-capable builds available and users can test stylesheets without having to build Mixxx on their own

IMO we should definitively pick that for 2.3 and subsequently style the menubars in point releases.
This feature has been requested for ages.

[Be-ing]

IMO we should definitively pick that for 2.3 and subsequently style the menubars in point releases.

I think that effort would be better spent getting rid of the menu bar.

[ronso0]

IMO we should definitively pick that for 2.3 and subsequently style the menubars in point releases.

I think that effort would be better spent getting rid of the menu bar.

There's already the next step in progress #3189 getting rid of the menu bar. After that we'll have to rework The Menu (however that will look like) and make it accessible for screen readers.
That'll take ages, and 2.3 will be the stable version for ~2 years :: looking at our release tempo o_o`
That said, it doesn't make much sense to me accepting the current situation while the styling groundwork is already done here.

@poelzi I you don't have time to split off the menubar theming prerequisities I'll open a separate PR with that commit and finish it in the next weeks.

[ronso0]

I picked up 851adbe for #3372

[ronso0]

Alright, I managed to adjust sizes and margins of the menu item, checkboxes & icons by using em

PR coming soon...

At first I was puzzled why the font-sizes wouldn't react to OS font size changes, then I realized it would only obey font settings made in qtconfig / Qt5 Settings (thus the italic font above).
I think we should not mess with the menu font settings since those are important accessibility parameters users need to be able to adjust by themselves (and we don't have to worry about the layout as we have to in the Mixxx skins), so either omitting menu font sizes in the stylesheets or setting them to 1em ensures readable menus and should not create accessibility regressions.

By setting some aburd font I also noticed that Mixxx font settings are not complete: Qt config could screw up GUI buttons, labels, table headers etc. I think there are only a few adjustments missing, so I guess I can fix all of them for 2.3, too.

[poelzi]

@ronso0 I removed the skin styling commits here and only left the large VU meter option in deer, the dimmed background image in VU and the increase in background color in the libraries. I adjusted them individually depending on how clear the background is visible.

[ronso0]

re large VU meter in Deere:
some tweaking is necessary to align it with some channel controls. ronso0@c9dc500 shoud do the trick.

re track colors:
LGTM, could you also increase it in Shade?

[ronso0]

btw I made some good progress with the menubar styling (Deere only as of now).
I hope to finish that and apply the styles to the other skins this week.

[ronso0]

re large VU meter in Deere:
some tweaking is necessary to align it with some channel controls. ronso0@c9dc500 shoud do the trick.

re track colors:
LGTM, could you also increase it in Shade?

btw to keep the commit history clean please make use of git --fixup ... and git rebase -i --autosquash for this PR because a) it is rather small and b) more about the effect than about reviewable code. https://fle.github.io/git-tip-keep-your-branch-clean-with-fixup-and-autosquash.html
thx!

[poelzi]

@ronso0 I tried your patch but the spacing on top just did not make sense for me. The purpose of the large VU option is, to use as much space as possible for the main VU meter. Only the spacer on the bottom for crossfader assignment was required otherwise it looked strange.

[ronso0]

@poelzi I'll take another look at this during the weekend.

[ronso0]

@poelzi I know the Deere mixer can be a pita to work with but in this branch the alignment of the large Main VU is horrible in some configurations. We should not sacrifice asthetics just for having a large VU meter.
Please try to fix that somehow with conditional spacers.

Edit whoopsy, the VU alignment is broken in 2.3 already: with 2 decks and crossfader hidden the EQs and VUs look for example.

[poelzi]

I was not able to reproduce this on my branch, it always looks ok

[ronso0]

this is the config I refer to: 4 decks, separate waveforms

how does that look like for you?

please just add some spacers for this config and we can merge.

[ronso0]

with ronso0@95db5d7 it looks like this, there's an offset only when there's no quick effect configured

pick this, double-check that it looks okay to you and then we can merge.

[ronso0]

ronso0@95db5d7

[poelzi]

@ronso0 done, looks good here

[ronso0]

Okido, the rest LGTM
Thanks!