Use a combobox instead of a lineedit widget for library search history #3171

poelzi · 2020-10-12T22:56:26Z

Use a combobox instead of a lineedit widget and utalize the combobox
selection mechanism for restoring and saving search queries.
This allows to go back to earlier queries easily and also
allows to restore the last search from a different feature.

Entries in the combobox are added after a 5 second timeout or
when the search is changed via api.

Properly query the frame width from the stylesheet and not assume 1.

The current data model is only in memory and not saved to disk.

selection mechanism for restoring and saving search queries. This allows to go back to earlier queries easily and also allows to restore the last search from a different feature. Entries in the combobox are added after a 5 second timeout or when the search is changed via api. Properly query the frame width from the stylesheet and not assume 1. The current data model is only in memory and not saved to disk.

poelzi · 2020-10-12T22:56:44Z

Be-ing · 2020-10-12T23:31:18Z

Saving these persistently could be added later after the basic feature is merged.

Be-ing · 2020-10-12T23:31:51Z

How about autocompletion?

ronso0 · 2020-10-12T23:37:16Z

It was in a b2b session just a few days ago that I decided to take a stab on this because it is sooo annoying to retype queries like bpm:=122-128 or tech vocal.
thanks for working on this!

src/widget/wsearchlineedit.cpp

ronso0 · 2020-10-13T00:04:02Z

at least with arrow buttons recalling previous queries feels a bit defective

search BOO, Enter
search FAR, Enter
search OOPS, Enter
clear search for a new querie
press down repeatedly: FAR, BOO show up
press up: BOO, FAR, OOPS

ronso0 · 2020-10-13T00:37:03Z

We should remove line 105 setFocusPolicy(Qt::ClickFocus); in order to make the lineedit focusable again so keyboards and controllers can access the query history. (librarycontrol would need to be adjusted, too, I guess)

ronso0 · 2020-10-13T01:00:31Z

After having selected any feature where searching is disabled, the placeholder is added to the query list

ronso0 · 2020-10-13T01:04:44Z

Applying the library font is fixed with ronso0@0d491ad
It was both an issue in the cpp as well as a hard-coded font for QComboBox in LateNight.
Though, increasing the font makes the searchbox grow immediately while decreasing the font doesn't shrink the box until the text is changed. This is bareable IMO...

I can help with auto-resizing the down button later on if you like.

Update internal metrics to calculate button positions on font changes. Move the new entry to the top of the list when an old entry was found. This way the search behaves more like expected. Avoid duplicates when Enter is pressed. Save new query term if keydown is pressed or popup opened.

poelzi · 2020-10-13T10:44:32Z

@ronso0 I fixed the resize problem and changed the history algorithm to move the old search entry to the top of the list and in general should behave more like expected.
@Be-ing autocompletion works out of the box with the default model/completer. This of course can be enhanced later on, like suggesting filter terms like "~key" etc. I could also imagine a dao for saving the queries in the database, but at this point, I'm ok with having this only at runtime.

… searchbox-combo

Cancle timer when selection changes to prevent history being messed up with arrow keys/controls.

poelzi · 2020-10-13T20:49:10Z

I think this is ready for review. I did some more testing and tweaked the behavior and think it behaves now as one would expect.

ronso0 · 2020-10-13T20:53:45Z

We should remove line 105 setFocusPolicy(Qt::ClickFocus); in order to make the lineedit focusable again so keyboards and controllers can access the query history.

...with Tab, Up, Down and existing library controls like [Library],MoveFocus, ..MoveVertical

With combobox reaching the search field is usefull again since it allows you to scroll previous filters.

poelzi · 2020-10-14T23:37:15Z

@ronso0 fixed

src/widget/wsearchlineedit.cpp

src/widget/wsearchlineedit.h

src/controllers/controlpickermenu.cpp

src/library/librarycontrol.cpp

src/preferences/dialog/dlgpreflibrary.cpp

src/widget/wsearchlineedit.cpp

…ueries with [Library],MoveVertical, ..MoveDown & MoveUp controls.

ronso0 · 2020-10-15T19:16:39Z

@poelzi
I was wrong, there's more necessary to allow scrolling through the search queries with [Library],Move...
check 118f4e5 (maybe this can be optimized, or I didn't cover all cases)

…s table

ronso0 · 2020-10-16T18:25:35Z

...as well as 5797c14: [Library],GoToItem jumps from searchbox to tracks table (skips Clear button & sidebar)

have used this branch in a few sessions now and it's very handy. Thanks!

text() does not exist anymore

src/library/librarycontrol.cpp

Be-ing · 2020-10-27T15:17:11Z

@uklotzde anything left to do here?

uklotzde · 2020-10-27T15:19:36Z

@uklotzde anything left to do here?

I will not re-review or test before the pre-commit issues have been fixed and the CI builds succeed.

src/widget/wsearchlineedit.cpp

poelzi · 2020-10-29T20:48:00Z

@uklotzde it's green now :)

ronso0 · 2020-10-29T21:22:51Z

nice!
I adjusted the drop-down styles in LateNight.
Do we want to add this here or in another PR?

src/widget/wsearchlineedit.cpp

ronso0 · 2020-10-29T21:28:46Z

nice!
I adjusted the drop-down styles in LateNight.
Do we want to add this here or in another PR?

forget about it... I'll do this all at once later on.

uklotzde

The width of the search box (and sidebar) grows with the longest search string. Suddenly the sidebar takes half of the screen's width and cannot be shrunk back.

Expected behavior: The width of the sidebar is controlled by the user and does not depend on the contents of the search combo box.

poelzi · 2020-10-29T22:17:17Z

@uklotzde good catch. fixed

uklotzde

Thanks for this powerful extension! Works really good now, especially in conjunction with the related tracks search.

I have only done a quick test, no keyboard navigation, no controller interaction.

ronso0 · 2020-10-29T23:12:25Z

🎉

ronso0 · 2020-10-31T13:29:28Z

@poelzi Please document the new controls and shortcut(s) in the PR description.

uklotzde · 2020-11-03T00:09:26Z

https://bugs.launchpad.net/mixxx/+bug/1902597

ronso0 requested changes Oct 12, 2020

View reviewed changes

src/widget/wsearchlineedit.cpp Show resolved Hide resolved

This comment has been minimized.

Sign in to view

WSearchLineEdit: apply library font to both QLineEdit and QListView

0d491ad

Holzhaus added library ui labels Oct 13, 2020

poelzi force-pushed the searchbox-combo branch from 63f8825 to b992c17 Compare October 13, 2020 10:42

poelzi added 2 commits October 13, 2020 12:49

Merge branch 'apply-lib-font' of https://github.com/ronso0/mixxx into…

1a5b9d5

… searchbox-combo

Implement control object for navigating history

b74f850

Cancle timer when selection changes to prevent history being messed up with arrow keys/controls.

Allow tab key emulation to reach search bar again.

407ae68

With combobox reaching the search field is usefull again since it allows you to scroll previous filters.

uklotzde suggested changes Oct 15, 2020

View reviewed changes

WSearchLineEdit: fully enable controllers to scroll previous search q…

118f4e5

…ueries with [Library],MoveVertical, ..MoveDown & MoveUp controls.

WSearchLineEdit: when focused use [Library],GoToItem to jump to track…

5797c14

…s table

poelzi added 2 commits October 17, 2020 17:59

Fix debug assert in searchbox

11a4a34

text() does not exist anymore

fix wrong control name

9424035

Be-ing changed the title ~~Use a combobox instead of a lineedit widget and utalize the combobox~~ Use a combobox instead of a lineedit widget for library search history Oct 27, 2020

Rename history search control, fix typo

0b5adb2

poelzi requested review from Be-ing and Holzhaus October 27, 2020 12:13

Be-ing reviewed Oct 27, 2020

View reviewed changes

src/library/librarycontrol.cpp Outdated Show resolved Hide resolved

Check for values ge 1.0

f12cb97

Be-ing approved these changes Oct 27, 2020

View reviewed changes

ronso0 reviewed Oct 27, 2020

View reviewed changes

src/widget/wsearchlineedit.cpp Outdated Show resolved Hide resolved

ronso0 mentioned this pull request Oct 29, 2020

[WIP] Adjust skin styles to show the onsceen keyboard during libary search #3231

Draft

poelzi added 2 commits October 29, 2020 16:41

rename padding argument

94dfdb2

make pre commit happy again

8fdd642

poelzi force-pushed the searchbox-combo branch from 411a92a to 8fdd642 Compare October 29, 2020 15:51

uklotzde reviewed Oct 29, 2020

View reviewed changes

src/widget/wsearchlineedit.cpp Outdated Show resolved Hide resolved

uklotzde suggested changes Oct 29, 2020

View reviewed changes

poelzi added 2 commits October 29, 2020 22:47

fix camelcase

787f770

Fix widget size on very long entries in the history

9e29613

uklotzde approved these changes Oct 29, 2020

View reviewed changes

Be-ing merged commit 524c41a into mixxxdj:main Oct 29, 2020

ronso0 added a commit to ronso0/manual that referenced this pull request Sep 28, 2021

Document searchbox controls from mixxxdj/mixxx#3171

7a9d6a6

ronso0 mentioned this pull request Sep 28, 2021

Search controls mixxxdj/manual#434

Merged

ronso0 mentioned this pull request Dec 16, 2022

Smart crates / save and recall search queries #5575

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use a combobox instead of a lineedit widget for library search history #3171

Use a combobox instead of a lineedit widget for library search history #3171

poelzi commented Oct 12, 2020

poelzi commented Oct 12, 2020

Be-ing commented Oct 12, 2020

Be-ing commented Oct 12, 2020

ronso0 commented Oct 12, 2020

This comment has been minimized.

ronso0 commented Oct 13, 2020

ronso0 commented Oct 13, 2020

ronso0 commented Oct 13, 2020

ronso0 commented Oct 13, 2020

poelzi commented Oct 13, 2020

poelzi commented Oct 13, 2020

ronso0 commented Oct 13, 2020

poelzi commented Oct 14, 2020

ronso0 commented Oct 15, 2020

ronso0 commented Oct 16, 2020

Be-ing commented Oct 27, 2020

uklotzde commented Oct 27, 2020

poelzi commented Oct 29, 2020

ronso0 commented Oct 29, 2020

ronso0 commented Oct 29, 2020

uklotzde left a comment

poelzi commented Oct 29, 2020

uklotzde left a comment

ronso0 commented Oct 29, 2020

ronso0 commented Oct 31, 2020

uklotzde commented Nov 3, 2020

Use a combobox instead of a lineedit widget for library search history #3171

Use a combobox instead of a lineedit widget for library search history #3171

Conversation

poelzi commented Oct 12, 2020

poelzi commented Oct 12, 2020

Be-ing commented Oct 12, 2020

Be-ing commented Oct 12, 2020

ronso0 commented Oct 12, 2020

This comment has been minimized.

ronso0 commented Oct 13, 2020

ronso0 commented Oct 13, 2020

ronso0 commented Oct 13, 2020

ronso0 commented Oct 13, 2020

poelzi commented Oct 13, 2020

poelzi commented Oct 13, 2020

ronso0 commented Oct 13, 2020

poelzi commented Oct 14, 2020

ronso0 commented Oct 15, 2020

ronso0 commented Oct 16, 2020

Be-ing commented Oct 27, 2020

uklotzde commented Oct 27, 2020

poelzi commented Oct 29, 2020

ronso0 commented Oct 29, 2020

ronso0 commented Oct 29, 2020

uklotzde left a comment

Choose a reason for hiding this comment

poelzi commented Oct 29, 2020

uklotzde left a comment

Choose a reason for hiding this comment

ronso0 commented Oct 29, 2020

ronso0 commented Oct 31, 2020

uklotzde commented Nov 3, 2020