Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine/loopingcontrol: Fix precision loss (wrong use of int) #3126

Merged
merged 2 commits into from
Sep 26, 2020
Merged

engine/loopingcontrol: Fix precision loss (wrong use of int) #3126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90b63fb
engine/loopingcontrol: Fix precision loss (wrong use of int)
Holzhaus Sep 25, 2020
d953941
CHANGELOG: Add entry for double precision fixes (#3126, #3127)
Holzhaus Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* Add controller mapping for Hercules DJControl Jogvision #2370
* Fix missing manual in deb package lp:1889776
* Fix caching of duplicate tracks that reference the same file #3027
* Fix loss of precision when dealing with floating-point sample positions while setting loop out position and seeking using vinyl control #3126 #3127

==== 2.2.4 2020-05-10 ====

Expand Down
2 changes: 1 addition & 1 deletion src/engine/loopingcontrol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ void LoopingControl::setLoopOutToCurrentPosition() {
BeatsPointer pBeats = m_pBeats;
LoopSamples loopSamples = m_loopSamples.getValue();
double quantizedBeat = -1;
int pos = m_currentSample.getValue();
double pos = m_currentSample.getValue();
if (m_pQuantizeEnabled->toBool() && pBeats) {
if (m_bAdjustingLoopOut) {
double closestBeat = m_pClosestBeat->get();
Expand Down