Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LV2 wrapper #3089

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Fix LV2 wrapper #3089

merged 2 commits into from
Oct 13, 2020

Conversation

poelzi
Copy link
Contributor

@poelzi poelzi commented Sep 10, 2020

The LV2 environment variable is required for the subsystem
to find the enabled plugins.

This functionality got lost when the default.nix -> shell.nix transition happened.

The LV2 environment variable is required for the subsystem
to find the enabled plugins.
@poelzi
Copy link
Contributor Author

poelzi commented Sep 11, 2020

There is something odd with the build packages. Investigating.

@Holzhaus Holzhaus marked this pull request as draft September 12, 2020 21:51
@daschuer
Copy link
Member

Is this still in draft state?

@poelzi
Copy link
Contributor Author

poelzi commented Oct 9, 2020

I fixed the wrapper problem and now LV2 plugins work again, which was a regression when the file was refactored.
I added the dependencies forpre-commit in virtualenv. On my 19.04 the shipped version is to old for getting this runnig. I tried to port it into this nix but it got to bloated, so i choose virtualenv.

@poelzi poelzi marked this pull request as ready for review October 9, 2020 22:49
Install dependencies for pre-commit hock and
ensure pre-commit is properly installed when
using nix-shell
@poelzi
Copy link
Contributor Author

poelzi commented Oct 12, 2020

please merge

@daschuer
Copy link
Member

Thank you for taking care.

@daschuer daschuer merged commit a9204b3 into mixxxdj:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants