double-click WTrackProperty to open DlgTrackInfo

[ronso0]

Double-click any track property label in decks to quickly open the track metadata editor popup.
applies to WTrackProperty and WTrackText

Discussed there https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/Track.20property.3A.20quick.20edit.20mode.20in.20decks

[Holzhaus]

Idea: Can we focus the corresponding field? I.e. if I double click the track title, the property windows opens with that field focused and the text selected, so that I can just type something and press enter to save and close the window.

[ronso0]

hmm, don't know. This would require WTrackProperty to send the property and DlgTrackInfo have corresponding focus targets.
fwiw, I noticed the previously focused field is focused again after closing/re-opening the dialog.

Directly opening an editor for the clicked property matches @daschuer 's proposal, but with this method we cannot access fields not visible in skins (comment, album etc.).
This could implemented separately to open on 'selected click' (delayed double-click).

[Holzhaus]

If we focus the field in the full dlgtraackinfo window, you can still select a different field to edit manually (without focusing the field you would need to do that anyway).

[ronso0]

I don't know what you refer to.
The alternative proposal is to open a single edit field (Qlinedit like in Cue menu), thus we could only address fields visible in skins:

In the current full DlgTrackInfo navigation with Tab is easy as you'd need the keyboard for typing anyway.
The only minor downside I noticed that the comment field (QPlainTextEdit) doesn't have the same focus border as the other QLineEdit fields (at least with my OS theme).

[Holzhaus]

I was replying to this:

Directly opening an editor for the clicked property matches @daschuer 's proposal, but with this method we cannot access fields not visible in skins (comment, album etc.).
This could implemented separately to open on 'selected click' (delayed double-click).

I think it's better to just open the full DlgTrackInfo window. That way you can still edit any property regardless if it's exposed in skins or not. It's just that the edit field for the property you double clicked on is pre-selected. If you want to edit a different field from what you clicked on, you can still use tab or the mouse.

[ronso0]

so we're on the same page :)

[ronso0]

Ready for merge btw

[ronso0]

wow, used this for two days now and I love it! I don't look back how cumbersome metadata editing was before..
Basically, since I was just building on top of it: thanks again @hacksdump for making the track context availbale in decks!

[ronso0]

Comments are addressed:
we use mouseDoubleClickEvent now, and I added the behaviour to WTrackText, too (used in preview deck).
Sqashed, ready for merge.

[Holzhaus]

LGTM, thank you!