-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execute tests in binary dir #2938
Conversation
I am currently testing whether we can get rid of manually specifying the working directory completely. |
Yep, works. We can just rely on defaults :) |
Would be great if we could merge this soon, before these extraneous files are merged into everything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
AppVeyor Windows builds on master seem to be failing since this PR has been merged!? The test data files are not available in cmake_build directory:
|
This needs to be fixed urgently! |
Oof, this is weird. Why does it work on Linux? |
Prevents the creation of the test files, which were accidentally committed in 0cd2aec, in the project root. Instead use the binary dir.
See https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/Running.20tests.20with.20ctest.20creates.20untracked.20files/near/203089624