Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute tests in binary dir #2938

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Execute tests in binary dir #2938

merged 2 commits into from
Jul 13, 2020

Conversation

xeruf
Copy link
Contributor

@xeruf xeruf commented Jul 13, 2020

Prevents the creation of the test files, which were accidentally committed in 0cd2aec, in the project root. Instead use the binary dir.

See https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/Running.20tests.20with.20ctest.20creates.20untracked.20files/near/203089624

@xeruf
Copy link
Contributor Author

xeruf commented Jul 13, 2020

I am currently testing whether we can get rid of manually specifying the working directory completely.

@xeruf xeruf force-pushed the tests-workingdir branch from dbb68e4 to 2c01a03 Compare July 13, 2020 12:19
@xeruf
Copy link
Contributor Author

xeruf commented Jul 13, 2020

Yep, works. We can just rely on defaults :)

@xeruf
Copy link
Contributor Author

xeruf commented Jul 13, 2020

Would be great if we could merge this soon, before these extraneous files are merged into everything.
Also, should I maybe point it to one of the stable branches (2.3) to also have it there?

Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Holzhaus Holzhaus merged commit 26c9602 into mixxxdj:master Jul 13, 2020
@uklotzde
Copy link
Contributor

uklotzde commented Jul 14, 2020

AppVeyor Windows builds on master seem to be failing since this PR has been merged!?

The test data files are not available in cmake_build directory:

TagLib - Cannot read audio properties from inaccessible/unreadable/invalid file: 
MetadataSourceTagLib - No track metadata or cover art found in file "C:/projects/mixxx/cmake_build/src/test/id3-test-data/TOAL_TPE2.mp3" with type 3
..\src\test\trackupdate_test.cpp(93): error: Value of: pTrack->isMetadataSynchronized()
  Actual: false
Expected: true

@uklotzde
Copy link
Contributor

This needs to be fixed urgently!

@xeruf
Copy link
Contributor Author

xeruf commented Jul 15, 2020

Oof, this is weird. Why does it work on Linux?

@xeruf xeruf deleted the tests-workingdir branch July 31, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants