add White Noise effect

[katsar0v]

I create an active noise effect. Here is a demo, in combination with filter and tremolo (wav in zip):

noise_effect_demo.zip

It has a "Loudness" parameter for adjusting the noise volume

[Be-ing]

How about we rename this "White Noise"?

[katsar0v]

Sure, it is actually called white noise, yes, will commit

[katsar0v]

Here is a new screenshot of the White Noise effect

[katsar0v]

It seems that the build fails, because QRandomGenerator could not be found. It was introduced with Qt 5.10, which version does Travis use and which Qt version should be used for development? I have 5.12

[Holzhaus]

It seems that the build fails, because QRandomGenerator could not be found. It was introduced with Qt 5.10, which version does Travis use and which Qt version should be used for development? I have 5.12

This decision is currently being discussed here: https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/minimum.20requirements.20policy

If we need to support Qt 5.10 for Mixxx 2.4, you need to make a QT_VERSION_CHECK that falls back qrand and divide the result by RAND_MAX. You can grep the source to see how the version check is used in other parts of the code base.

[katsar0v]

Ok, I will add this, thank you

[Be-ing]

Please sign the Mixxx Contributor Agreement before we can merge your code. Leave a comment when you have signed.

[katsar0v]

I signed the agreement

[katsar0v]

It seems that the build fails with scons, but succeeds with cmake. Is there something I can do to fix this? It complains about undefined reference which I don't understand

[Holzhaus]

It seems that the build fails with scons, but succeeds with cmake. Is there something I can do to fix this? It complains about undefined reference which I don't understand

You only added the file to CMakeLists.txt, not to build/depends.py.

[katsar0v]

Got it, okay I will commit tomorrow and fix this. Thank you

[Be-ing]

This is more fun than I expected. I am glad you decided to work on it despite my scepticism. :) There are many potential chains to play with using this. I had fun with White Noise -> BitCrusher -> Moog Filter.

[uklotzde]

@katsar0v Please improve both the scope of your commits and your commit messages. Otherwise this will introduce a lot of noise into our commit history and complicate bisecting. This becomes unhandy within the scope of a large project.

If changes do not add real value from an outside perspective that could be summarized by a concise commit message then don't commit those changes individually. You could do this locally, but then please reorder and stash your commits into reasonable chunks before opening a PR.

I recommend to stash all the of commits of this branch before merging. The intermediate commits mostly document your personal learning process and don't add any value for the project.

See also: Zulip: commit message format

[uklotzde]

I suggest to stash the intermediate commits. Some of them don't even build.

[Be-ing]

The artefact when enabling/disabling and load the effect is gone now that previous_drywet is initialized to 0. 👍

[Be-ing]

Sounds good to me! Just waiting for the CI builds to pass.

[Be-ing]

Travis macOS SCons build timed out but everything else passed. We should really get rid of SCons ASAP so we can save time on CI. The CMake builds go way faster with CCache.

[vespadj]

Dear developers, @katsar0v, @Be-ing, @Holzhaus, @uklotzde,
I would like to bring this topic to your attention:
#11868 improve usability of White Noise effect
Thank you