Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAAD2 Patch for 2.3 #2863

Merged
merged 20 commits into from
Jun 13, 2020
Merged

FAAD2 Patch for 2.3 #2863

merged 20 commits into from
Jun 13, 2020

Conversation

uklotzde
Copy link
Contributor

Follow-up of #2850. Once again I missed to adjust the target branch.

Same source branch and commits, different target branch.

uklotzde and others added 20 commits June 7, 2020 20:40
@uklotzde
Add NeAACDecGetVersion to LibFaadLoader
abd320e
@uklotzde
Add missing const-qualifiers for methods of LibFaadLoader
e4d3bba
@uklotzde
Log FAAD2 version string after loading the dynamic library
e324776
@uklotzde
Log FAAD2 decoder configuration
946e769
@uklotzde
FAAD2: Do not set defObjectType to LC
ed6dbf1
@uklotzde
Enclose FAAD2 types and constants in faad2 namespace
bfd0746
@uklotzde
Replace const with constexpr
332c5e2
@uklotzde
Declare member as const
862a056
@uklotzde
Initialize FAAD2 decoder in separate function
354db66
@uklotzde
SoundSourceM4A: Recover from FAAD2 2.9.x channel errors
5309bab
@uklotzde
FAAD2: Reconfigure decoder after channel config errors
7c94bff
@uklotzde
Ignore unsupported file formats in SoundSourceProxyTest
b442828
@daschuer
Don't make NeAACDecGetVersion mandatory
22d4ead
@daschuer
CMake: Enable the FAAD2 loader on Linux by default
5b2fcda
@uklotzde
Merge pull request #15 from daschuer/faad2
c775f33 
Faad2 + CMake
@uklotzde
Reorder and add comments
c8f682f
@uklotzde
Improve code formatting
256db1d
@uklotzde
Add comments and a debug assertion about error recovery
f3dcc8a
@uklotzde
Improve readability by skipping the remaining loop body
8ce43f4
@uklotzde
Add comment about "potentially" discontinuous decoding
7ec1dbf
@uklotzde uklotzde added this to the 2.3.0 milestone Jun 13, 2020
@uklotzde uklotzde requested a review from daschuer June 13, 2020 11:55
@daschuer
Copy link
Member

Ups, I missed that either. Sorry.

daschuer
daschuer approved these changes Jun 13, 2020
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daschuer
Copy link
Member

Strange:

The following tests FAILED:

	175 - DurationUtilTest.formatSecondsLong (Failed)

Errors while running CTest

The command "ctest" exited with 8.

@daschuer daschuer merged commit 0b1393c into mixxxdj:2.3 Jun 13, 2020
@Holzhaus
Copy link
Member

Just a fluke again. I guess xvfb is not that stable. Can we disable GUI/X support except for the tests that actually need it?

175/618 Test #175: DurationUtilTest.formatSecondsLong ..............................................***Failed    0.07 sec
qt.qpa.screen: QXcbConnection: Could not connect to display :99.0
Could not connect to any X display.

@uklotzde uklotzde deleted the faad2 branch June 14, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
major bug
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @daschuer @Holzhaus