Mapping for Numark iDJ Live II

[nkorth]

I wrote up a wiki page too: https://mixxx.org/wiki/doku.php/numark_idj_live_ii

Since I've never actually used another DJ controller, I'm not super confident about the scratch parameters. It feels reasonable to me, and I'm pretty sure I at least got the resolution right.

[Swiftb0y]

Looks good so far, though I don't think the search accumulator behavior is a good feature. You could simplify the code drastically, if you instead you just speed up the jogwheel while in search mode instead of beatjumping.

[Swiftb0y]

For future reference, you should not develop in the master branch but instead create a feature branch for your mapping and then develop within that.
Also make sure you linted the js:
https://www.mixxx.org/wiki/doku.php/contributing_mappings#automated_code_checking_linting

[nkorth]

I don't think the search accumulator behavior is a good feature.

Fair enough, it's just something I personally like. Do you have an example of a mapping I could imitate for a search mode? (I was looking at the Ion Discover DJ mapping, but I don't think it's a very good one. It just pitch bends when scratch mode is off, even when paused.)

[Be-ing]

It is common for controller mappings to use shift + jog wheel turn to seek quickly.

[Be-ing]

Could you map the sync button LED to sync_enabled?

[nkorth]

Updated with more normal search mode

Could you map the sync button LED to sync_enabled?

fixed

[Holzhaus]

@nkorth Can you update the text about the sync LEDs on the wiki page?

Also, please rebase this PR on 2.2 or 2.3: https://mixxx.org/wiki/doku.php/using_git#targeting_another_base_branch
Otherwise it will only be included in the 2.4 release, so you'd have to wait at least until end of this year...

[nkorth]

Github pull requests confuse me. I rebased it in a new branch here, do I have to create a whole new pull request in order to use that branch? Do I have to clobber nkorth:master with the contents of mixxx:2.3?

[Holzhaus]

Github pull requests confuse me. I rebased it in a new branch here, do I have to create a whole new pull request in order to use that branch? Do I have to clobber nkorth:master with the contents of mixxx:2.3?

Generally, you should work in feature branches and never commit to master. Now that you already opened this PR and used your master branch for it, let's just continue using it and not open a new PR:

# Switch to the source branch for this PR
git checkout master
# Create a copy of the current branch for backup purposes
git branch -c idjl2-master-backup
# Set the state of the current branch to the rebased version
git reset --hard idjl2_controller
# Push the changes to this PR
git push -f origin master

[nkorth]

Done.

[Holzhaus]

LGTM.

[Holzhaus]

Before we merge your code into Mixxx, please sign the contributor agreement. In a nutshell, this gives us permission to distribute your code under the GPL as well as in the Mac App Store which has some terms incompatible with the GPL.

[Holzhaus]

Also, can you add an entry to CHANGELOG.md?

[nkorth]

qt.qpa.screen: QXcbConnection: Could not connect to display :99.0
Could not connect to any X display.

I assume this is a flaky test and not the result of my change?

[Holzhaus]

LGTM, thank you!