Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude .ts files from Transifex from pre-commit-hook #2796

Merged
merged 1 commit into from
May 17, 2020
Merged

Exclude .ts files from Transifex from pre-commit-hook #2796

merged 1 commit into from
May 17, 2020

Conversation

uklotzde
Copy link
Contributor

The .ts files are pulled from Transifex and not edited locally. The pre-commit-hook fails after those files have been updated recently.

@uklotzde uklotzde added the build label May 17, 2020
@uklotzde uklotzde added this to the 2.3.0 milestone May 17, 2020
@uklotzde uklotzde requested a review from Holzhaus May 17, 2020 07:51
daschuer
daschuer approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 3202b28 into mixxxdj:master May 17, 2020
@uklotzde
Copy link
Contributor Author

🙈 Once again I forgot to switch the target branch from master to 2.3. I will do the cherry-pick for 2.3!

@uklotzde uklotzde deleted the exclude_transifex_ts_files_from_pre-commit-hooks branch May 17, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

@Holzhaus Holzhaus Awaiting requested review from Holzhaus

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @daschuer