TrackDAO: Reformat code / Avoid mutex locks on Track object #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFAIC everything is ready to merge now. |
|
OK, so lets wait here. |
|
I have so many pending pull requests that I need to suspend working on Mixxx. This is becoming unmanageable. |
|
I have just pushed the 2.3 branch so this can be merged to master now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This technical PR will reduce the number of merge conflicts that I already experience frequently.
TrackRecordinstead ofTrackto avoid repeated locking of mutexes. The additional copy shouldn't matter since all dynamically allocated C++ objects are implicitly shared (Qt)Both changes affect a single part of the code.