Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Beats et al. to mixxx namespace #2751

Merged
merged 1 commit into from
May 5, 2020

Conversation

JaviVilarroig
Copy link
Contributor

@JaviVilarroig JaviVilarroig commented May 5, 2020

This is just a technical PR. I have moved the Beats class, and associated ones, to the mixxx namespace.

@Be-ing
Copy link
Contributor

Be-ing commented May 5, 2020

Looks good to me. Anyone else want to take a look?

@Be-ing
Copy link
Contributor

Be-ing commented May 5, 2020

Do we have any guidelines on what belongs in the mixxx namespace? There doesn't seem to be any pattern that I have noticed.

@JaviVilarroig
Copy link
Contributor Author

JaviVilarroig commented May 5, 2020

I understood from the Coding guidelines that we wanted top have a mixxx namespace to contain all the mixxx classes, at some point.
I also understood that we wanted to have classes moved to mixxx namespace when we work on them.
This is "in preparation" for #2512

@Holzhaus
Copy link
Member

Holzhaus commented May 5, 2020

Do we have any guidelines on what belongs in the mixxx namespace? There doesn't seem to be any pattern that I have noticed.

Most newer stuff goes into the mixxx Namespace. I think it makes sense to gradually switch over all our code to this namespace to avoid naming clashes with third party libraries.

@Be-ing Be-ing merged commit 8c29fce into mixxxdj:master May 5, 2020
@JaviVilarroig JaviVilarroig deleted the Move_Beats_to_mixxx_namespace branch May 6, 2020 07:25
@daschuer
Copy link
Member

Hi @JaviVilarroig, I have just noticed that we are missing your contributor agreement.
This is required to release you patch with Mixxx
Please sign https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ
And comment here when done.
Thank you very much.

@JaviVilarroig
Copy link
Contributor Author

JaviVilarroig commented May 10, 2021 via email

@daschuer
Copy link
Member

Thank you. That was quick :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants