Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused class WidgetHider #2676

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Remove unused class WidgetHider #2676

merged 2 commits into from
Apr 17, 2020

Conversation

uklotzde
Copy link
Contributor

Did I miss something? I guess this dead code.

@uklotzde uklotzde added this to the 2.3.0 milestone Apr 17, 2020
@Be-ing
Copy link
Contributor

Be-ing commented Apr 17, 2020

ripgrep doesn't find anything you missed, this builds and runs, so I guess it was unused legacy code.

@Be-ing Be-ing merged commit e3ab409 into mixxxdj:master Apr 17, 2020
@uklotzde uklotzde deleted the widgethider branch April 17, 2020 20:07
@JosepMaJAZ
Copy link
Contributor

Sorry, I didn't see this before.
Yes, that class can be removed.
I added it on 2.0 to improve the recording preferences so that I could dinamically modify the dialog.
After several attemps and migration of Qt, it no longer served a purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @Be-ing @JosepMaJAZ