-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CueInfo DTO #2523
Add CueInfo DTO #2523
Conversation
@uklotzde Sorry, I fixed up the commits. The only thing missing is a decision about moving the constants into global namespace: https://github.com/mixxxdj/mixxx/pull/2523/files/d0fb17ca6faaf4c59d58067f826d32de55eef187#diff-1483dfb71fc243bb08cf3cb33a1d5c5c |
@Holzhaus Rebuild this PR as needed and deliberately drop any intermediate versions that are not worth keeping in the final commit history. |
Done ;-) |
By the way, should I put this class into the |
I've just started that once. It helps to prevent name clashes with external libraries. It is still not consistently applied, yet. Yes, maybe that would be an option for such a foundational component. |
Done. |
If nothing else is missing, let's merge. I can rebase #2499 on master then. |
Done. |
Ok, I guess this is ready now. |
LGTM. Thank you, Jan, for getting this rework started! |
This adds a
CueInfo
class that does not have any dependencies onTrack
orCue
. To archieve this, we use positions in milliseconds instead of sample positions, so that we don't need to know the tracks' sample rate.The
Track
object gets a new method to import cues from a list ofCueInfo
objects.This would be useful for Serato Markers Integration (PR #2499).
Also see related Zulip discussion for details:
https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/2.2E3.20planning/near/189265725