Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/osx/otool: Fix indentation errors using black #2498

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

Holzhaus
Copy link
Member

These errors cause TabErrors in Python and let some OSX builds on
Travis CI fail.

These errors cause TabErrors in Python and let some OSX builds on
Travis CI fail.
@daschuer
Copy link
Member

Codefactor finds a bunch of issues.
Do you have interest to fix them here or should we just merge?

@Holzhaus
Copy link
Member Author

Holzhaus commented Feb 13, 2020

I'd say we just merge. The code violates a bunch of Python best pratices and I don't want to rewrite most parts of it if we're going to drop SCons anyway.

@daschuer
Copy link
Member

Ok. Thank you.

@daschuer daschuer merged commit 4d0e51e into mixxxdj:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants