Add support for the SeratoMarkers_ GEOB tag (Hotcues/Loops/Track Color) #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79d8cd3 to
2d65a58
Compare
daschuer
requested changes
Feb 10, 2020
| << (quint8)m_type | ||
| << (quint8)m_isLocked; | ||
| return data; | ||
| } |
There was a problem hiding this comment.
This also required a lot comments, including examples.
|
I almost completely rewrote the parser code using |
daschuer
requested changes
Feb 11, 2020
|
Merge? |
daschuer
reviewed
Feb 16, 2020
daschuer
reviewed
Feb 16, 2020
daschuer
reviewed
Feb 16, 2020
daschuer
reviewed
Feb 16, 2020
daschuer
reviewed
Feb 16, 2020
daschuer
reviewed
Feb 16, 2020
b76aecd to
c9a38e5
Compare
|
Had to remove the last commit since it made the tests fail |
daschuer
approved these changes
Feb 16, 2020
|
LGTM, Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This augments the
Serato Markers2tag parser that was added in #2323. TheSerato Markers_contains the first 5 Hotcues, the first 9 saved loops and the library track color.All of this information (and more) is also stored in the
Serato Markers2tag, but Serato will prefer information from this tag if it's present. If we add support for writingSerato Markers2, we should also writeSerato Markers_because otherwise our changes would not be picked up by Serato.