include full build of Lodash #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also disable strict mode, which somehow breaks with QJSEngine and Qt 5.12.
|
I searched the Qt bug tracker for new issues with |
|
Actually, I'm thinking it would be better to remove the dependency on Lodash and use plain ES7... |
|
Superceded by ferranpujolcamins#6 |
|
Following discussion on Zulip, I changed my mind. I think we should merge this to keep compatibility with Qt 5.9 in #1795 for Ubuntu 18.04 LTS. |
13 tasks
|
Any objections or should we merge this? |
|
No objections. Including the whole, unmodified library should reduce the risk to confuse mapping developers. Ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some mapping developers have asked for this and I don't think there's a good reason not to include all of Lodash. We are not optimizing every kilobyte of download size for a website in this context.
Also disable strict mode, which somehow breaks with QJSEngine (#1795) and Qt 5.12.