Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tango :: some improvements #1930

Merged
merged 7 commits into from
Dec 3, 2018
Merged

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Dec 3, 2018

The major change here is to have identical loop sections for left & right decks.
Initially, I tried to have all related controls close to each other, that's why the beatjump controls were directly below the Play button. While this is useful for mouse-only users, it turned out to be an annoying contradiction to how beatloop size & beatjump size encoder are positioned on controllers. I repeatedly looked at the wrong spinbox when turning the beatjump size encoder on the right deck of my controller... (left encoder: loop size, right encoder: jump size)
Now, loop/jump section is the same on each deck and the fillers are improved to visually attach those sections more to the decks above.

Other changes:

  • fixed position of Master/head mixer hide/show button in top row
  • adjust vinyl control buttons so that vinyl/passthrough enable buttons are easier to distinguish
  • yellow Pfl icon to match other indicators (it was white previously)
  • removed size parameter from elapsed/remaning track time so future time formats automatically fit in
  • renamed templates to ease maintenance

before:
tango-loopjump-before

after:
tango-loopjump-after

@daschuer
Copy link
Member

daschuer commented Dec 3, 2018

LGTM. Thank you.

@daschuer daschuer merged commit d73ffc2 into mixxxdj:2.2 Dec 3, 2018
@ronso0 ronso0 deleted the tango-parallel-loopcontrols branch December 6, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants