let Key widget display key, cents or both (or nothing) #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This alllows to have separate widgets for key & key cents that for example can react to space constraints individually.
daschuer
reviewed
Dec 3, 2018
src/widget/wkey.cpp
Outdated
| if (m_displayKey) { | ||
| keyStr = KeyUtils::keyToString(key); | ||
| } | ||
| else if (m_displayCents) { |
There was a problem hiding this comment.
woopsy..such a small PR, and such a mistake.... fixed.
|
LGTM. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is supposed to fix the position of key +- buttons within the expanding key edit widget in Deere.
Before, those buttons where moving under the mouse cursor when the Key widget switches in between short<>long strings of key/cents.
This introduces a
<DisplayKey>tag to use the WKey widget to display the key value only, cents only or both.In Deere I used it to have two separate widgets for key and cents, with static overall width:
I choose a medium width for key/cents so OpenKey/Lancelot values don't look lonesome, and most single traditional values fit in nicely. Only double values like
D♯m/E♭mare cropped.Traditional notation:
OpenKey:
