Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add a fixed autodj tab to the library #1681

Conversation

nopeppermint
Copy link
Contributor

on top of #1671 I like to add a optional, fixed autodj tab to the library, as shown here with latenight

this autodj tab on the right will be fixed on autodj, therefore no controll buttons are required for this tab, just one button on the toolbar to enable/disable this option

This would be a really useful tab for me, as at the moment I am switching constantly from autodj view to tracks/playlist or crates view..

autodj_no_tab
autodj_tab

ronso0 and others added 24 commits May 18, 2018 23:50
@nopeppermint nopeppermint changed the title add a fixed autodj tab to the library WIP: add a fixed autodj tab to the library May 22, 2018
@nopeppermint
Copy link
Contributor Author

nopeppermint commented May 22, 2018

at the moment Autodj is fixed to this special tab and can not be used on the first tab, even if the second is not displayed... so this is not the final solution, except this is a new feature and autodj could be only used in this new tab from now on ;-)

@Be-ing
Copy link
Contributor

Be-ing commented May 22, 2018

Let's work on flexible, robust designs instead of hacks that only work for one specific use case.

@ronso0
Copy link
Member

ronso0 commented May 22, 2018

@nopeppermint
I remember a very long discussion about how to design the multi-pane library, and we worked towards a solution that fits more than one use case. If you're impatient to wait for this, just built a private branch ;)
Please refer to the first (or second?) lib redesign PR. I don't find it right now, but starting at the middle part of the discussion, there were a lot of illustrated ideas how to deal with multiple button bars and so on.

@ronso0
Copy link
Member

ronso0 commented May 23, 2018

I don't find it right now,

Got it, it's actually #1117 But that chat is looong so you'd have to expand hundreds of hidden items.
Have a look at around July 2017

@nopeppermint
Copy link
Contributor Author

ok

@nopeppermint nopeppermint mentioned this pull request May 11, 2020
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants