Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt6.8: Ensure Mixxx uses "windowsvista" Qt style on Windows #14228

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

JoergAtGithub
Copy link
Member

  • Ensure Mixxx uses "windowsvista" Qt style on Windows, as our skinning looks inconsistent with Qt's "windows" or "windows11" styles
  • Add logging of the selected style on all platforms

@daschuer
Copy link
Member

Does QT_STYLE_OVERRIDE environment variable still work? I think it should if user needs to fix a corner case.

Do we want to make the 2.5 branch also work with the 2.6 environment? I can imagine that this can be convenient for us developers.

@JoergAtGithub
Copy link
Member Author

No it does not work - and I do not plan to spend work for this env variable, which we never documented.
If you prefer, I retarget this to 2.5.

@daschuer
Copy link
Member

Yes. Please Target 2.5.

@daschuer
Copy link
Member

This is working for all Qt applications by default:
https://doc.qt.io/qt-6/qapplication.html#QApplication

This code breaks it for windows.

The main issue is that Qt prints also a warning message that a certain style is used for override. This message is wrong if we change it afterwards and should be avoided.

It looks like QApplication::setStyle("windowsvista"); can be set outside QApplication, before MixxxApplication().
This way QT_STYLE_OVERRIDE will still work and everything is fine.

@JoergAtGithub JoergAtGithub changed the base branch from main to 2.5 January 26, 2025 16:01
… looks inconsistent with Qt's "windows" or "windows11" styles

Add logging of the selected style on all platforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants