stem waveformrenderer using rendergraph #14192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolombier
approved these changes
Jan 19, 2025
acolombier
reviewed
Jan 19, 2025
10 tasks
|
Some conflict have developed - Happy to merge once resolved! |
|
I have resolved this conflict, but I have one doubt: in main we use ControlProxy, and here we use PollingControlProxy. One of the conflicts was around this code. I think the change to PollingControlProxy comes from you, right? |
|
Yes, that's right - a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the stem waveformrenderer to a rendergraph node. This can be reviewed and merged independently from the PRs for the other waveformrenderers.