markrange waveformrenderer using rendergraph

[m0dB]

Ports the markrange waveformrenderer to a rendergraph node. This can be reviewed and merged independently from the PRs for the other waveformrenderers.

[acolombier]

Looks like there is an issue with range. For example with an active loop here, the play position is going beyond the end marker

[m0dB]

I can't reproduce this, @acolombier , but it also don't see how this could be caused by this PR.

If you set loop points, the range is drawn exactly where you set it, right? And if you close the track and re-open it, the range is where you expect it?

If this is the case, the range code is working. The fact that your play position goes beyond. the end marker must be something else. Is it only visual or also audible?

[JoergAtGithub]

It could also be that the visual playposition is wrong. The related code to determine it is here: VisualPlayPosition::determinePlayPosInLoopBoundries

[m0dB]

Ping @acolombier . Can you provide more info?

[acolombier]

If you set loop points, the range is drawn exactly where you set it, right? And if you close the track and re-open it, the range is where you expect it?

No, it seems to have a slightly offset. But it could be the play position which is now quite where it should be!

Is it only visual or also audible?

Only visual.
I'll try to provide a recording asap to help with debugging!

[acolombier]

I tried again and I couldn't reproduce neither on legacy nor QML UI! No idea why this was a problem previously.

[acolombier]

LGTM, Thanks!