endoftrack waveformrenderer using rendergraph #14187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolombier
previously requested changes
Jan 19, 2025
src/waveform/renderers/allshader/waveformrendererendoftrack.cpp
Outdated
Show resolved
Hide resolved
src/waveform/renderers/allshader/waveformrendererendoftrack.cpp
Outdated
Show resolved
Hide resolved
| const float posx1 = size.width() / 2.f; | ||
| const float posx2 = size.width(); | ||
| const float posy1 = 0.f; | ||
| const float posy2 = size.height(); |
There was a problem hiding this comment.
Might need to add a static_cast here
10 tasks
using qstringliteral Co-authored-by: Antoine Colombier <7086688+acolombier@users.noreply.github.com>
|
Looks like the pre-commit is failing, do you want me to push the fix? |
|
I don't understand that, I ran pre-commit on the file locally and nothing changed. Anyway, I applied to edit as shown in the error. |
Swiftb0y
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the endoftrack waveformrenderer to a rendergraph node. This can be reviewed and merged independently from the PRs for the other waveformrenderers.