Update to libdjinterop 0.24.3 - support for Engine 4.1/4.2 #14172
Conversation
|
QQ: I've set this PR to merge into the |
| m_pVersionCombo->insertItem(0, | ||
| QString::fromStdString(version.name), | ||
| QString::fromStdString(to_application_version_string(schemaVersion)), |
There was a problem hiding this comment.
A breaking change introduced in recent libdjinterop is that the "versions" that it works with are now aligned with the database schema (i.e. the Engine Library), rather than the marketing versions of the apps that use the schema (Engine OS, Engine DJ).
This is a more reliable model. For user-friendliness, the new to_application_version_string() provides the human-readable description of the apps associated with this schema.
There was a problem hiding this comment.
I'm a little unfamiliar with engine OS. Can the user easily check what schema version(s) their hardware supports?
There was a problem hiding this comment.
The schema isn't exposed to the end user - they will see a friendly name in the drop-down as before:
|
Putting this back to draft whilst I fix some cross-platform build issues... |
5f2cf4e to
f412016
Compare
Yes. But we need to update vcpkg as well and we need the PPA source package. |
I'm always careful after last time, because it seems as soon as I upload a new package to the PPA, Launchpad considers the old one fair game for auto-deleting! So I may do this last. |
|
Have bumped to version 0.24.3 in order to fix an issue with the Ubuntu package. This is now built: https://launchpad.net/~xsco/+archive/ubuntu/djinterop @JoergAtGithub apologies, we'll need to bump the vcpkg build to 0.24.3 for consistency. However, we do know that 0.24.2 built successfully so hopefully this won't cause any trouble. Thanks. |
|
Ah I remember. Since libdjinterop requires the EXACT version anyway we did not require a vcpkg update. Did you consider to keep a stable ABI at one point? The requirement would be that old builds, let's say requiring 0.22 will also compile with 0.24. |
This is definitely on the cards for a 1.x release of libdjinterop. I don't have much experience of maintaining a stable ABI on C++ libraries before, but was thinking of trying out tools like abidiff and integrating checks into the CI pipeline. I've raised an issue for this: xsco/libdjinterop#146 |
Update to libdjinterop
0.23.20.24.3, which provides support for Engine 4.1/4.2, i.e. the latest.Tested successfully on my SC5000 hardware.
Once happy with the basic local build, we can update the package in the PPA and vcpkg.