fix: make hotcue_focus_color_next/_prev COs ControlPushButtons
#13764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two issues: 1. The Control is not accessible via the controller mapping XML 2. The Control ignores nops, leading to confusing why `engine.setValue(group, ..., 1)` was only working on the first press (which is a confusion that comes up because this is not the case for other button-like controls, since those are implemented using `ControlPushButton`).
|
I tested this PR on Ubuntu 22.04 and can confirm it works as expected |
|
Thanks for confirming. |
|
LGTM, but shouldn't this go into 2.4 ? |
|
yup, of course. Forgot to set the right branch when filing the PR. |
|
Thank you! |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues:
engine.setValue(group, ..., 1)was only working on the first press (which is a confusion that comes up because this is not the case for other button-like controls, since those are implemented usingControlPushButton).Both issues were raised on Zulip.