Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger QML waveform slot at init #13736

Merged

Conversation

acolombier
Copy link
Member

This fix the bug where the waveform isn't displayed when loading QML with a track already loaded (can be reproduced by loading a track, and trigger a QML reload with a touch on any used QMl file, e.g res/qml/main.qml)

@github-actions github-actions bot added the qml label Oct 8, 2024
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Swiftb0y Swiftb0y merged commit 38e82db into mixxxdj:main Oct 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants