Musicbrainz: Elide long error messages in the progress bar #13673
Conversation
src/library/dlgtagfetcher.cpp
Outdated
| QString cantConnect = tr("Can't connect to %1: %2").arg(app, message); | ||
| QFontMetrics metrics(loadingProgressBar->font()); | ||
| QString elidedCantConnect = metrics.elidedText( |
|
I wonder if we need the full error string/url at all. Besides, I wouldn't expect a tooltip on a progressbar. |
src/library/dlgtagfetcher.cpp
Outdated
| Qt::ElideRight, | ||
| loadingProgressBar->width() - 4); | ||
| loadingProgressBar->setFormat(elidedCantConnect); | ||
| if (cantConnect.size() != elidedCantConnect.size()) { |
There was a problem hiding this comment.
Is there the possibility of the edge case that the elided text has the same length as the non-elided text? Could this happen when the text gets elided but then the added ellipses pads it back out to the same length again? That would cause information to be missing (not much sure, but still a character or two) and no tooltip being shown.
Unless we know this is a performance problem, I would just always set the tooltip. makes the code simpler and avoids the edge case.
There was a problem hiding this comment.
Right, that is likely, but no gurantee, because the elipsis can be either the … (https://www.compart.com/de/unicode/U+2026) or ... (three dots) depending on the font.
We show the translated error string form the Qt backend that is intendend to be displayed to the user. So I consider it a good idea to show it. The errror message is long if it contains a long path auto generated path, so eliding will probably not cut off sigificant data and we may consider to remove the tooltip.
Only if the original message is too long and independent froem the preferendes. This was just a quick workaround. If you prefer I will remove the tooltip. Please give a hint. |
|
Merge? @ronso0 Is that OK for now? |
And put the full text into a tooltip, like we do in the library table.
This fixes #13664