Track Info dialogs: move metatdata buttons below color picker #13632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
reviewed
Sep 6, 2024
Comment on lines
-440
to
+432
| <item row="0" column="0"> | ||
| <item row="10" column="0"> |
There was a problem hiding this comment.
do you know why this was row="0" previously?
There was a problem hiding this comment.
🤷♂️
items with the same position are stacked, that's why we didn't notice.
There was a problem hiding this comment.
so the spacer was overlayed on another object somewhere near the top of the table, effectively not existing?
There was a problem hiding this comment.
yup. that's what I noticed with QLabels when I messed up column/row values.
There was a problem hiding this comment.
Great. thanks for the clarification then.
|
Thanks for the quick review! |
cr7pt0gr4ph7
added a commit
to cr7pt0gr4ph7/mixxx
that referenced
this pull request
Oct 31, 2024
…ck-info-dialog Resolved conflicts caused by mixxxdj#13632 (Move metatdata buttons below color picker).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.