Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Reloop Beatmix 4 eject button #13601

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Fix Reloop Beatmix 4 eject button #13601

merged 1 commit into from
Aug 25, 2024

Conversation

sblaisot
Copy link
Member

@sblaisot sblaisot commented Aug 25, 2024 •
edited
Loading

Fix Reloop Beatmix 2/4 controller mapping eject button (long press on load deck button) by fixing typo introduced by #12401

@sblaisot sblaisot requested a review from Swiftb0y August 25, 2024 21:55
ronso0
ronso0 approved these changes Aug 25, 2024
View reviewed changes
Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix LGTM, thanks!

Please rebase onto 2.4 so it'll be availble in 2.4.2

@sblaisot sblaisot changed the base branch from main to 2.4 August 25, 2024 22:28
@sblaisot
Copy link
Member Author

Please rebase onto 2.4 so it'll be availble in 2.4.2

Done

@ronso0 ronso0 merged commit d6f9423 into mixxxdj:2.4 Aug 25, 2024
1 check passed
@ronso0 ronso0 added this to the 2.4.2 milestone Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronso0 ronso0 ronso0 approved these changes

@Swiftb0y Swiftb0y Awaiting requested review from Swiftb0y

Assignees
No one assigned
Labels
controller mappings
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@sblaisot @ronso0