Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fix trivial cpp coreguideline violations #13552

Merged
merged 5 commits into from
Aug 10, 2024
Merged

Refactor fix trivial cpp coreguideline violations #13552

merged 5 commits into from
Aug 10, 2024

Conversation

Swiftb0y
Copy link
Member

@Swiftb0y Swiftb0y commented Aug 9, 2024

see individual commit messages

daschuer
daschuer approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor code style comment. Do you want to "fix" it?

@daschuer daschuer merged commit 1dc1b9b into mixxxdj:main Aug 10, 2024
13 checks passed
@Swiftb0y
Copy link
Member Author

Thanks.

@Swiftb0y Swiftb0y deleted the refactor/trivial-cpp-core-guideline-violations branch August 10, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
analyzer code quality controller backend effects library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swiftb0y @daschuer