Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve Taglib/SoundSource logging #13541

Merged
merged 1 commit into from
Aug 18, 2024
Merged

improve Taglib/SoundSource logging #13541

merged 1 commit into from
Aug 18, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Aug 6, 2024

  • log taglib::FileType enum as string (char*)
  • omit file:// prefix for local files

@JoergAtGithub
Copy link
Member

Looks good on Windows, e.g.:

info [BrowseThread] MetadataSourceTagLib - No track metadata or cover art found in file "C:/Users/Joerg.WORLDWARTWEB/Music/Mixxx/Recordings/2022-12-28_16h55m19s.wav" of type "WAV"

Thank you!

@JoergAtGithub JoergAtGithub merged commit 5e7dec8 into mixxxdj:2.5 Aug 18, 2024
13 checks passed
@ronso0 ronso0 deleted the logging-taglib-soundsource branch August 18, 2024 13:54
@ronso0 ronso0 added this to the 2.5.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
soundsource
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ronso0 @JoergAtGithub