Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundManagerIOS: Remove unsupported/redundant options #13487

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Jul 19, 2024

On iPadOS using AVAudioSessionCategoryOptionAllowAirPlay seems to throw an AVAudioSessionErrorCodeBadParam and according to the docs it only seems to be allowed when the category is set to AVAudioSessionCategoryPlayAndRecord (which we don't). This PR therefore removes it.

The option AVAudioSessionCategoryOptionAllowBluetoothA2DP seems to be redundant too, this seems to already be covered by AVAudioSessionCategoryPlayback (the category that we use for now), therefore we remove it too.

In the future we may wish to investigate using AVAudioSessionCategoryMultiRoute for more fine-grained control over audio routing, but this also seems to disable the device's volume buttons, so we should look into this more deeply before using this configuration.

@fwcd fwcd added the ios label Jul 19, 2024
@fwcd fwcd mentioned this pull request Jul 19, 2024
54 tasks
@m0dB
Copy link
Contributor

m0dB commented Jul 19, 2024

Reading the apple docs, I agree with your assessment.

@m0dB m0dB merged commit 7c852d6 into mixxxdj:main Jul 19, 2024
13 checks passed
@fwcd fwcd deleted the soundmanagerios-remove-redundant-options branch July 19, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants